Mfrhtyj

I created a module that overrides ImageUploader like so:

<preference 

    for="MagentoCatalogModelImageUploader" 

    type="MyCompanyMyModuleModelCatalogImageUploader" />

The code looks like this (don't ask why, but we are only allowing jpg images):

<?php



namespace MyCompanyMyModuleModelCatalog;



class ImageUploader extends MagentoCatalogModelImageUploader {



    /**

     * @param string $allowedExtensions

     */

    public function setAllowedExtensions($allowedExtensions)

    {

        parent::setAllowedExtensions(['jpg', 'jpeg']);

    }

}

I installed the module and the other parts work just fine. But this does not prevent me from uploading a PNG. Anyone have any ideas of what I might be doing wrong or what I should override instead of this?

Thanks!

Take a look at vendor/magento/module-catalog/etc/di.xml

    <virtualType name="MagentoCatalogCategoryImageUpload" type="MagentoCatalogModelImageUploader">

        <arguments>

            <argument name="baseTmpPath" xsi:type="string">catalog/tmp/category</argument>

            <argument name="basePath" xsi:type="string">catalog/category</argument>

            <argument name="allowedExtensions" xsi:type="array">

                <item name="jpg" xsi:type="string">jpg</item>

                <item name="jpeg" xsi:type="string">jpeg</item>

                <item name="gif" xsi:type="string">gif</item>

                <item name="png" xsi:type="string">png</item>

            </argument>

        </arguments>

    </virtualType>

In this case, we need to override MagentoCatalogCategoryImageUpload, not MagentoCatalogModelImageUploader.

Our custom class will be the virtual type class. So, we need to re-inject the dependencies.

Your di.xml should be:

<?xml version="1.0"?>



<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">

    <preference

            for="MagentoCatalogCategoryImageUpload"

            type="VendorModuleModelCatalogImageUploader" />



    <virtualType name="VendorModuleModelCatalogImageUploader" type="MagentoCatalogModelImageUploader">

        <arguments>

            <argument name="baseTmpPath" xsi:type="string">catalog/tmp/category</argument>

            <argument name="basePath" xsi:type="string">catalog/category</argument>

            <argument name="allowedExtensions" xsi:type="array">

                <item name="jpg" xsi:type="string">jpg</item>

                <item name="jpeg" xsi:type="string">jpeg</item>

                <item name="gif" xsi:type="string">gif</item>

                <!--<item name="png" xsi:type="string">png</item>-->

            </argument>

        </arguments>

    </virtualType>

</config>